Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Destroy the right pointer in collectUnicodes #77

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Fix: Destroy the right pointer in collectUnicodes #77

merged 1 commit into from
Apr 9, 2023

Conversation

papandreou
Copy link
Contributor

Right now face.collectUnicodes creates a temporary set, but frees the pointer holding the face itself instead of the temporary set at the end -- probably a copy/paste error. This leads to RuntimeError: memory access out of bounds when using the face after that.

@papandreou papandreou mentioned this pull request Apr 8, 2023
Merged
@behdad behdad merged commit e56768b into harfbuzz:main Apr 9, 2023
@papandreou
Copy link
Contributor Author

Thanks! Mind doing a patch release with this change? 🤗

@behdad
Copy link
Member

behdad commented Apr 14, 2023

I think @khaledhosny can do that.

@khaledhosny
Copy link
Contributor

I think @khaledhosny can do that.

Done

@papandreou
Copy link
Contributor Author

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @behdad @khaledhosny